[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
From: |
no-reply |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups |
Date: |
Wed, 27 Feb 2019 07:26:32 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ba3f93c692 hw/arm hw/xtensa: De-duplicate pflash creation code some
f99ab9fe08 pflash: Clean up after commit 368a354f02b part 2
e98231996b pflash: Clean up after commit 368a354f02b part 1
fd218de008 mips_malta: Clean up definition of flash memory size somewhat
413850d478 r2d: Flash memory creation is confused about size, mark FIXME
d23c64b271 ppc405_boards: Don't size flash memory to match backing image
db2935d503 sam460ex: Don't size flash memory to match backing image
856425f0be hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
09fa7495d9 pflash: Macro PFLASH_BUG() is used just once, expand
83625c2e47 pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit 83625c2e4780 (pflash: Rename pflash_t to PFlashCFI01,
PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 09fa7495d9a5 (pflash: Macro PFLASH_BUG() is used just
once, expand)
3/10 Checking commit 856425f0be58 (hw: Use CFI_PFLASH0{1, 2} and
TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit db2935d50313 (sam460ex: Don't size flash memory to match
backing image)
5/10 Checking commit d23c64b27139 (ppc405_boards: Don't size flash memory to
match backing image)
6/10 Checking commit 413850d478aa (r2d: Flash memory creation is confused about
size, mark FIXME)
7/10 Checking commit fd218de008eb (mips_malta: Clean up definition of flash
memory size somewhat)
8/10 Checking commit e98231996be7 (pflash: Clean up after commit 368a354f02b
part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#92: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#100: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit f99ab9fe08d8 (pflash: Clean up after commit 368a354f02b
part 2)
10/10 Checking commit ba3f93c692dd (hw/arm hw/xtensa: De-duplicate pflash
creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-block] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, (continued)
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/18
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/19
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/19
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/19
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/19
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups,
no-reply <=
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups, no-reply, 2019/02/27