[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [RFC PATCH 4/6] sysbus: Fix latent bug wit
Re: [Qemu-block] [Qemu-devel] [RFC PATCH 4/6] sysbus: Fix latent bug with onboard devices
Tue, 5 Mar 2019 08:17:24 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0
On 05/03/2019 07.54, Markus Armbruster wrote:
> Thomas Huth <address@hidden> writes:
>> On 25/02/2019 19.37, Markus Armbruster wrote:
>>> diff --git a/vl.c b/vl.c
>>> index e3fdce410f..6ce3d2d448 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -3990,6 +3990,10 @@ int main(int argc, char **argv, char **envp)
>>> object_property_add_child(object_get_root(), "machine",
>>> OBJECT(current_machine), &error_abort);
>> PS: Not directly related to your patch, but in a separate patch we
>> should also object_unref(current_machine) here to drop the superfluous
>> second reference to current_machine after we added it as a child of the
>> root object.
> Just for cleanliness. Makes sense.
Not only for cleanliness ... there is a TODO at the very end of vl.c
which we should fix one day, and for that we'd need the unref here.