[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/4] hw/i386/pc_sysfw: Remove obsolete PcSysFwDe
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-block] [PATCH 2/4] hw/i386/pc_sysfw: Remove obsolete PcSysFwDevice |
Date: |
Tue, 5 Mar 2019 18:19:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 03/04/19 20:48, Philippe Mathieu-Daudé wrote:
> This structure is not used since 6dd2a5c98a.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/pc_sysfw.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
> index 34727c5b1f..46b87afe23 100644
> --- a/hw/i386/pc_sysfw.c
> +++ b/hw/i386/pc_sysfw.c
> @@ -40,11 +40,6 @@
>
> #define BIOS_FILENAME "bios.bin"
>
> -typedef struct PcSysFwDevice {
> - SysBusDevice busdev;
> - uint8_t isapc_ram_fw;
> -} PcSysFwDevice;
> -
> static void pc_isa_bios_init(MemoryRegion *rom_memory,
> MemoryRegion *flash_mem,
> int ram_size)
>
Looks sane, and the commit reference is precise.
Reviewed-by: Laszlo Ersek <address@hidden>
Thanks
Laszlo
- [Qemu-block] [RFC PATCH 0/4] pc: Support firmware configuration with -blockdev (splitted), Philippe Mathieu-Daudé, 2019/03/04
- [Qemu-block] [PATCH 1/4] pflash_cfi01: Add pflash_cfi01_get_blk() helper, Philippe Mathieu-Daudé, 2019/03/04
- [Qemu-block] [PATCH 2/4] hw/i386/pc_sysfw: Remove obsolete PcSysFwDevice, Philippe Mathieu-Daudé, 2019/03/04
- Re: [Qemu-block] [PATCH 2/4] hw/i386/pc_sysfw: Remove obsolete PcSysFwDevice,
Laszlo Ersek <=
- [Qemu-block] [PATCH 3/4] hw/i386/pc_sysfw: Let pc_system_firmware_init() access PCMachineState, Philippe Mathieu-Daudé, 2019/03/04
- [Qemu-block] [RFC PATCH 4/4] pc: Support firmware configuration with -blockdev, Philippe Mathieu-Daudé, 2019/03/04
- Re: [Qemu-block] [Qemu-devel] [RFC PATCH 0/4] pc: Support firmware configuration with -blockdev (splitted), Markus Armbruster, 2019/03/06