[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v2] file-posix: add drop-cache=on|o

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v2] file-posix: add drop-cache=on|off option
Date: Wed, 6 Mar 2019 06:44:42 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 3/6/19 4:18 AM, Stefan Hajnoczi wrote:

>> Question - if we used qapi's 'if':COND to only declare the field on
>> platforms where we know at compile time that we can support it, would
>> that be enough for libvirt to introspect that if the field exists then
>> migration is safe, without having to rely on an query-qemu-features command?
> Yes, although this raises another question:
> The drop-cache implementation is not #ifdefed in file-posix.c.  If we
> make the QMP schema conditional, should we also #ifdef the command-line
> option in raw_runtime_opts[] to prevent QEMU from silently ignoring this
> option?

Yes, that would make sense to me - if we don't advertise the feature,
then we should not silently ignore it on the command line.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]