[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PULL 04/28] qapi: drop x- from x-block-la

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PULL 04/28] qapi: drop x- from x-block-latency-histogram-set
Date: Tue, 12 Mar 2019 15:31:03 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 3/12/19 2:31 PM, Kevin Wolf wrote:

>> ...but patch itself is correct. Not worth a v2 pull request, since it is
>> not user-visible.
> I just updated the tag without sending a formal v2, so Peter will pull
> the corrected version.

Only works insofar that we currently only require pull requests to be
signed tags, but not immutable emails (if Peter's workflow ever starts
flagging a mismatch between the commit hash mentioned in a signed pull
email request vs. where the tag actually points in the remote repo, then
we can't blindly reuse pull tags like that...)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]