[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.jso

From: Michal Privoznik
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash
Date: Fri, 15 Mar 2019 09:32:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3

On 3/14/19 8:01 PM, Markus Armbruster wrote:
Michal Privoznik <address@hidden> writes:

On 3/8/19 2:14 PM, Markus Armbruster wrote:
The previous commit added a way to configure firmware with -blockdev
rather than -drive if=pflash.  Document it as the preferred way.

Signed-off-by: Markus Armbruster <address@hidden>
   docs/interop/firmware.json | 20 ++++++++++++++------
   1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
index 28f9bc1591..ff8c2ce5f2 100644
--- a/docs/interop/firmware.json
+++ b/docs/interop/firmware.json
@@ -212,9 +212,13 @@
   # @executable: Identifies the firmware executable. The firmware
   #              executable may be shared by multiple virtual machine
-#              definitions. The corresponding QEMU command line option
-#              is "-drive
+#              definitions. The preferred corresponding QEMU command
+#              line options are
+#                  -drive 
+#                  -machine pflash0=pflash0

I have a question. How is libvirt supposed to query for this? How can
it learn it can use this new, preferred command line?

You can use qom-list-properties to find out whether the machine has
property pflash0.

---> {"execute": "qom-list-properties", "arguments": {"typename": 
<--- {"return": [... {"name": "pflash0", ...} ...]}
---> {"execute": "qom-list-properties", "arguments": {"typename": 
<--- {"return": [... no such property ...]}

Ah, very well, thank you.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]