[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock byte

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes
Date: Thu, 28 Mar 2019 19:40:08 +0100
User-agent: Mutt/1.11.3 (2019-02-01)

Am 28.03.2019 um 08:21 hat Vladimir Sementsov-Ogievskiy geschrieben:
> bdrv_replace_child() calls bdrv_check_perm() with error_abort on
> loosening permissions. However file-locking operations may fail even
> in this case, for example on NFS. And this leads to Qemu crash.
> Let's ignore such errors, as we do already on permission update commit
> and abort.
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>

I think this would better be fixed in block.c code so that unlock never
fails for any block driver.

But we're late for 4.0, so if fixing it in block.c proves difficult,
this might still be better than nothing and I could accept it as a
preliminary solution.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]