Re: [Qemu-block] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

[Eric Blake]

On 3/29/19 2:58 AM, Kevin Wolf wrote:

>>>> +seq="$(basename $0)"
>>>> +echo "QA output created by $seq"
>>>> +
>>>> +status=1 # failure is the default!
>>>> +
>>>> +nbd_unix_socket=$TEST_DIR/test_qemu_nbd_socket
>>>> +rm -f "${TEST_DIR}/qemu-nbd.pid"
>>>
>>> hmm, strange that we need to remove something from test directory at start.
>>
>> Well, until we follow through with our thread of implementing per-test
>> scratch directories for iotests, it proved invaluable to me during
>> testing (as a failed test does not properly clean up after itself).
> 
> Maybe that's the thing to fix then?
> 
> Though I'm not sure why, as you do call nbd_server_stop in _cleanup.
> Does this mean that _cleanup wasn't called at all in your failure case?
> 

I've dropped the line from my v3 posting. When I wrote v1, it was back
in the 3.1 timeframe, and pre-dated Dan's improvements to factor out NBD
functions into a reusable common file. Looks like I may have just missed
that during rebasing.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature