[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 5/5] qcow2-refcount: don't mask corruptions u
Re: [Qemu-block] [PATCH v5 5/5] qcow2-refcount: don't mask corruptions under internal errors
Fri, 29 Mar 2019 19:19:19 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
On 20.03.19 18:26, John Snow wrote:
> On 2/27/19 8:18 AM, Max Reitz wrote:
>> On 27.02.19 14:14, Vladimir Sementsov-Ogievskiy wrote:
>>> No reasons for not reporting found corruptions as corruptions in case
>>> of some internal errors, especially in case of just failed to fix l2
>>> entry (and in this case, missed corruptions may influence comparing
>>> logic, when we calculate difference between corruptions fields of two
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>>> block/qcow2-refcount.c | 19 +++++++++----------
>>> 1 file changed, 9 insertions(+), 10 deletions(-)
>> Reviewed-by: Max Reitz <address@hidden>
>> I'll be on PTO for a couple of weeks, so it doesn't make sense for me to
>> take this series to my branch now, though...
> Should we have staged this somewhere else? Is it non-applicable for
I was counting on the fact that I'm not the only maintainer. O:-)
> I suppose these are not "fixes."
Some are. Hm. But probably not for rc2, I think... I'll think about
it until Monday, but now this series probably should go to block-next.
Description: OpenPGP digital signature