[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH for-4.0?] iotests: Let 245 pass on
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH for-4.0?] iotests: Let 245 pass on tmpfs |
Date: |
Wed, 10 Apr 2019 18:39:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 10.04.19 18:39, Eric Blake wrote:
> On 4/10/19 11:29 AM, Max Reitz wrote:
>> tmpfs does not support O_DIRECT. Detect this case, and skip flipping
>> @direct if the filesystem does not support it.
>>
>> Fixes: bf3e50f6239090e63a8ffaaec971671e66d88e07
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> tests/qemu-iotests/245 | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> Are you trying to get this in 4.0-rc3? (As a test, it has no bearing on
> the actual binaries; fewer testsuite failures are nice if we squeeze it
> in, but at the same time it is not enough to delay the release if it
> does not get fixed until 4.1).
>
> Reviewed-by: Eric Blake <address@hidden>
If there are other patches for rc3, we could take this as well. But
there is no point in making a pull request just for this.
Max
signature.asc
Description: OpenPGP digital signature