[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not har
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash |
|
Date: |
Wed, 24 Apr 2019 16:23:52 +0100 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Wed, Apr 24, 2019 at 09:14:29AM -0500, Eric Blake wrote:
> On 4/24/19 5:37 AM, Thomas Huth wrote:
> > bash is installed in a different directory on non-Linux systems like
> > FreeBSD. Do not hard-code /bin/bash here so that the tests can run
> > there, too.
>
> These tests were obviously copy-and-pasted from a fork point prior to
> commit 11a82d14.
Is this a candidate for a checkpatch addition to reject any use
of /bin/bash in scripts ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-block] [PATCH 2/6] tests/qemu-iotests/group: Introduce a new "ci" group for CI pipelines, Thomas Huth, 2019/04/24