[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-next 0/2] qemu-img: Make create hint at prot
From: |
John Snow |
Subject: |
Re: [Qemu-block] [PATCH for-next 0/2] qemu-img: Make create hint at protocol options |
Date: |
Fri, 26 Apr 2019 18:57:03 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/13/19 11:20 AM, Max Reitz wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1698863 reports that while
> "qemu-img create -f raw" supports the "preallocation" option, it is not
> listed under "-o help".
>
> It turns out it is, but only if you specify a target filename. Users
> may not realize this, but a note should help.
>
>
> Max Reitz (2):
> iotests: Perform the correct test in 082
> qemu-img: Make create hint at protocol options
>
> qemu-img.c | 13 ++++++++++++-
> tests/qemu-iotests/082 | 5 ++++-
> tests/qemu-iotests/082.out | 25 ++++++++++++++++++-------
> 3 files changed, 34 insertions(+), 9 deletions(-)
>
Seems like an improvement to me.
Reviewed-by: John Snow <address@hidden>