[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 4/5] iotests: Use qemu-nbd's --pid-file
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 4/5] iotests: Use qemu-nbd's --pid-file |
Date: |
Tue, 7 May 2019 22:08:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 07.05.19 21:53, Eric Blake wrote:
> On 5/7/19 1:36 PM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> tests/qemu-iotests/common.rc | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
>> index 93f87389b6..217cf3874d 100644
>> --- a/tests/qemu-iotests/common.rc
>> +++ b/tests/qemu-iotests/common.rc
>> @@ -106,8 +106,8 @@ _qemu_io_wrapper()
>> _qemu_nbd_wrapper()
>> {
>> (
>> - echo $BASHPID > "${QEMU_TEST_DIR}/qemu-nbd.pid"
>> - exec "$QEMU_NBD_PROG" $QEMU_NBD_OPTIONS "$@"
>> + exec "$QEMU_NBD_PROG" --pid-file="${QEMU_TEST_DIR}/qemu-nbd.pid" \
>> + $QEMU_NBD_OPTIONS "$@"
>> )
>
> Beforehand, we needed the subshell + exec to guarantee that the pid we
> were writing was that of the subshell. Now, we don't need either; this
> could be simplified to:
>
> _qemu_nbd_wrapper()
> {
> "$QEMU_NBD_PROG" --pid-file... "$@"
> }
True, but I just followed _qemu_img_wrapper()’s example. I could change
both, of course...
Max
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-block] [PATCH 1/5] qemu-nbd: Add --pid-file option, Daniel P . Berrangé, 2019/05/08
[Qemu-block] [PATCH 2/5] iotests.py: Add qemu_nbd_early_pipe(), Max Reitz, 2019/05/07
[Qemu-block] [PATCH 4/5] iotests: Use qemu-nbd's --pid-file, Max Reitz, 2019/05/07
[Qemu-block] [PATCH 3/5] qemu-nbd: Do not close stderr, Max Reitz, 2019/05/07
[Qemu-block] [PATCH 5/5] iotests: Let 233 run concurrently, Max Reitz, 2019/05/07