[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make chec
From: |
Thomas Huth |
Subject: |
Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again |
Date: |
Fri, 10 May 2019 06:29:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 09/05/2019 20.08, Max Reitz wrote:
> On 02.05.19 10:45, Thomas Huth wrote:
>> People often forget to run the iotests before submitting patches or
>> pull requests - this is likely due to the fact that we do not run the
>> tests during our mandatory "make check" tests yet. Now that we've got
>> a proper "auto" group of iotests that should be fine to run in every
>> environment, we can enable the iotests during "make check" again by
>> running the "auto" tests by default from the check-block.sh script.
>>
>> Some cases still need to be checked first, though: iotests need bash
>> and GNU sed (otherwise they fail), and if gprof is enabled, it spoils
>> the output of some test cases causing them to fail. So if we detect
>> that one of the required programs is missing or that gprof is enabled,
>> we still have to skip the iotests to avoid failures.
>>
>> And finally, since we are using check-block.sh now again, this patch also
>> removes the qemu-iotests-quick.sh script since we do not need that anymore
>> (and having two shell wrapper scripts around the block tests seem
>> rather confusing than helpful).
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>> tests/Makefile.include | 8 +++----
>> tests/check-block.sh | 44 ++++++++++++++++++++++++++++---------
>> tests/qemu-iotests-quick.sh | 8 -------
>> 3 files changed, 38 insertions(+), 22 deletions(-)
>> delete mode 100755 tests/qemu-iotests-quick.sh
>
> Can I interest you in a Makefile target that explicitly excludes
> check-block? I run the iotests anyway, but I also run make check.
> Running some iotests twice would be a bit pointless.
Can't you simply run
./check -qcow2 -x auto
instead?
Thomas
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v4] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, (continued)
- [Qemu-block] [PATCH v4] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, Thomas Huth, 2019/05/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, Markus Armbruster, 2019/05/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, Kevin Wolf, 2019/05/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, Markus Armbruster, 2019/05/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, Kevin Wolf, 2019/05/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 6/7] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, Markus Armbruster, 2019/05/08
[Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Thomas Huth, 2019/05/02
- Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Alex Bennée, 2019/05/03
- Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Max Reitz, 2019/05/09
- Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again,
Thomas Huth <=
- Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Max Reitz, 2019/05/10
- Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Thomas Huth, 2019/05/10
- Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Max Reitz, 2019/05/10
- Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Thomas Huth, 2019/05/10
- Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Max Reitz, 2019/05/10
Re: [Qemu-block] [PATCH v3 7/7] tests: Run the iotests during "make check" again, Max Reitz, 2019/05/10