[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] nvme: fix copy direction in DMA reads going to
|
From: |
Keith Busch |
|
Subject: |
Re: [Qemu-block] [PATCH] nvme: fix copy direction in DMA reads going to CMB |
|
Date: |
Mon, 20 May 2019 09:05:57 -0600 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Sat, May 18, 2019 at 09:39:05AM +0200, Klaus Birkelund Jensen wrote:
> `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of
> `qemu_iovec_*from*_buf` when the request involved the controller memory
> buffer.
>
> Signed-off-by: Klaus Birkelund Jensen <address@hidden>
I was wondering how this mistake got by for so long, and it looks like
the only paths here require an admin command with dev->host transfer
to CMB. That's just not done in any host implementation I'm aware of
since it'd make it more difficult to use for no particular gain AFAICS,
so I'd be curious to hear if you have a legit implementation doing this.
Anyway, thanks for the fix.