[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed w
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed when reconectting |
|
Date: |
Wed, 29 May 2019 11:37:09 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 29/05/19 10:37, Jie Wang wrote:
> when the problem appeared:
>
> 1. qemu will initialize pr-helper and connect to it cyclically, but
> always failed because no running pr-helper process to connect.
>
> 2. libvirt will always waiting for connected event, but will never to
> start new pr-helper process because not receive disconnect event.
>
> I'm not found the best way to solve this problem, can you give me some
> suggestion?
I can't find a way that is better than your patch, either. Another
possible problem is that this could cause libvirt to spawn two helpers
if you have a race like
qemu: report DISCONNECTED
libvirt: start pr-helper #1
qemu: report DISCONNECTED
libvirt: start pr-helper #2
pr-helper #1: create socket
pr-helper #2: fail to start
But it should not be an issue since one of the two pr-helpers will clean
up after itself.
Paolo