Re: [Qemu-block] [Qemu-devel] [RFC PATCH] qemu-io-cmds: use clock_gettime for benchmarking

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC PATCH] qemu-io-cmds: use clock_gettime for 
benchmarking
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d6ebcb635a qemu-io-cmds: use clock_gettime for benchmarking

=== OUTPUT BEGIN ===
ERROR: space required after that ',' (ctx:VxO)
#132: FILE: qemu-io-cmds.c:895:
+    clock_gettime(CLOCK_MONOTONIC,&t1);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#132: FILE: qemu-io-cmds.c:895:
+    clock_gettime(CLOCK_MONOTONIC,&t1);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#135: FILE: qemu-io-cmds.c:897:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#135: FILE: qemu-io-cmds.c:897:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#153: FILE: qemu-io-cmds.c:1095:
+    clock_gettime(CLOCK_MONOTONIC,&t1);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#153: FILE: qemu-io-cmds.c:1095:
+    clock_gettime(CLOCK_MONOTONIC,&t1);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#162: FILE: qemu-io-cmds.c:1105:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#162: FILE: qemu-io-cmds.c:1105:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#180: FILE: qemu-io-cmds.c:1217:
+    clock_gettime(CLOCK_MONOTONIC,&t1);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#180: FILE: qemu-io-cmds.c:1217:
+    clock_gettime(CLOCK_MONOTONIC,&t1);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#183: FILE: qemu-io-cmds.c:1219:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#183: FILE: qemu-io-cmds.c:1219:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#202: FILE: qemu-io-cmds.c:1262:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#202: FILE: qemu-io-cmds.c:1262:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#214: FILE: qemu-io-cmds.c:1294:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#214: FILE: qemu-io-cmds.c:1294:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#223: FILE: qemu-io-cmds.c:1429:
+    clock_gettime(CLOCK_MONOTONIC,&ctx->t1);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#223: FILE: qemu-io-cmds.c:1429:
+    clock_gettime(CLOCK_MONOTONIC,&ctx->t1);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#232: FILE: qemu-io-cmds.c:1574:
+        clock_gettime(CLOCK_MONOTONIC,&ctx->t1);
                                      ^

ERROR: space required before that '&' (ctx:OxV)
#232: FILE: qemu-io-cmds.c:1574:
+        clock_gettime(CLOCK_MONOTONIC,&ctx->t1);
                                       ^

ERROR: space required after that ',' (ctx:VxO)
#250: FILE: qemu-io-cmds.c:1791:
+    clock_gettime(CLOCK_MONOTONIC,&t1);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#250: FILE: qemu-io-cmds.c:1791:
+    clock_gettime(CLOCK_MONOTONIC,&t1);
                                   ^

ERROR: space required after that ',' (ctx:VxO)
#253: FILE: qemu-io-cmds.c:1793:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                  ^

ERROR: space required before that '&' (ctx:OxV)
#253: FILE: qemu-io-cmds.c:1793:
+    clock_gettime(CLOCK_MONOTONIC,&t2);
                                   ^

total: 24 errors, 0 warnings, 214 lines checked

Commit d6ebcb635ac6 (qemu-io-cmds: use clock_gettime for benchmarking) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden