[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_jo
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create |
Date: |
Wed, 5 Jun 2019 19:11:37 +0200 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 05.06.2019 um 14:32 hat Vladimir Sementsov-Ogievskiy geschrieben:
> child_role job already has .stay_at_node=true, so on bdrv_replace_node
> operation these child are unchanged. Make block job blk behave in same
> manner, to avoid inconsistent intermediate graph states and workarounds
> like in mirror.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
This feels dangerous. It does what you want it to do if the only graph
change below the BlockBackend is the one in mirror_exit_common. But the
user could also take a snapshot, or in the future hopefully insert a
filter node, and you would then want the BlockBackend to move.
To be honest, even BdrvChildRole.stay_at_node is a bit of a hack. But at
least it's only used for permissions and not for the actual data flow.
Kevin
- [Qemu-block] [PATCH v2 0/2] introduce pinned blk, Vladimir Sementsov-Ogievskiy, 2019/06/05
- [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create, Vladimir Sementsov-Ogievskiy, 2019/06/05
- Re: [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create,
Kevin Wolf <=
- Re: [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create, Vladimir Sementsov-Ogievskiy, 2019/06/05
- Re: [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create, Kevin Wolf, 2019/06/06
- Re: [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create, Vladimir Sementsov-Ogievskiy, 2019/06/06
- Re: [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create, Kevin Wolf, 2019/06/06
- Re: [Qemu-block] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create, Vladimir Sementsov-Ogievskiy, 2019/06/06
[Qemu-block] [PATCH v2 1/2] block: introduce pinned blk, Vladimir Sementsov-Ogievskiy, 2019/06/05