[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] block/nbd: merge NBDClientSession struct ba
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [PATCH 3/3] block/nbd: merge NBDClientSession struct back to BDRVNBDState |
Date: |
Thu, 13 Jun 2019 15:20:56 +0000 |
13.06.2019 18:16, Eric Blake wrote:
> On 6/11/19 5:27 AM, Vladimir Sementsov-Ogievskiy wrote:
>> No reason to keep it separate, it differs from others block driver
>> behavior and therefor confuses. Instead of generic
>
> s/therefor/therefore/ (both spellings are valid, but the former looks
> archaic)
Interesting, for me it was just a mistake.
>
>> 'state = (State*)bs->opaque' we have to use special helper.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>> block/nbd.c | 197 +++++++++++++++++++++++++---------------------------
>> 1 file changed, 94 insertions(+), 103 deletions(-)
>>
>
> Reviewed-by: Eric Blake <address@hidden>
>
> I'm queuing this series through my NBD tree.
>
Thanks!! I'll rebase reconnect series on this.
--
Best regards,
Vladimir