Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode

[John Snow]

I have clearly been lax in checking my coding style...

I'll fix these, but not until review.

On 7/3/19 9:50 PM, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
> Message-id: address@hidden
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Switched to a new branch 'test'
> 18acfee block/backup: loosen restriction on readonly bitmaps
> 4852213 iotests: add test 257 for bitmap-mode backups
> 0d47743 iotests: Add virtio-scsi device helper
> 9805af4 iotests: teach FilePath to produce multiple paths
> b491804 iotests: teach run_job to cancel pending jobs
> 2925d97 iotests: add testing shim for script-style python tests
> c7870c0 block/backup: add 'always' bitmap sync policy
> 1a5bc8c block/backup: upgrade copy_bitmap to BdrvDirtyBitmap
> a7fd32c block/dirty-bitmap: add bdrv_dirty_bitmap_get
> 6ec8d60 block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal
> 8760b33 hbitmap: enable merging across granularities
> 919477d hbitmap: Fix merge when b is empty, and result is not an alias of a
> dd0775a block/backup: add 'never' policy to bitmap sync mode
> 998d008 block/backup: Add mirror sync mode 'bitmap'
> 5e678f1 qapi: add BitmapSyncMode enum
> 7e58e56 blockdev-backup: utilize do_backup_common
> e372afa drive-backup: create do_backup_common
> 677b04c qapi/block-core: Introduce BackupCommon
> 
> === OUTPUT BEGIN ===
> 1/18 Checking commit 677b04c0b13d (qapi/block-core: Introduce BackupCommon)
> 2/18 Checking commit e372afac0fdc (drive-backup: create do_backup_common)
> 3/18 Checking commit 7e58e56768db (blockdev-backup: utilize do_backup_common)
> 4/18 Checking commit 5e678f15e446 (qapi: add BitmapSyncMode enum)
> 5/18 Checking commit 998d0084971b (block/backup: Add mirror sync mode 
> 'bitmap')
> 6/18 Checking commit dd0775a4cf92 (block/backup: add 'never' policy to bitmap 
> sync mode)
> WARNING: Block comments use a leading /* on a separate line
> #26: FILE: block/backup.c:269:
> +        /* Failure, or we don't want to synchronize the bitmap.
> 
> WARNING: Block comments use a trailing */ on a separate line
> #27: FILE: block/backup.c:270:
> +         * Merge the successor back into the parent, delete nothing. */
> 
> total: 0 errors, 2 warnings, 25 lines checked
> 
> Patch 6/18 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 7/18 Checking commit 919477d56466 (hbitmap: Fix merge when b is empty, and 
> result is not an alias of a)
> 8/18 Checking commit 8760b336946d (hbitmap: enable merging across 
> granularities)
> 9/18 Checking commit 6ec8d60f0329 (block/dirty-bitmap: add 
> bdrv_dirty_bitmap_merge_internal)
> 10/18 Checking commit a7fd32c4817d (block/dirty-bitmap: add 
> bdrv_dirty_bitmap_get)
> ERROR: open brace '{' following function declarations go on the next line
> #36: FILE: block/dirty-bitmap.c:517:
> +bool bdrv_dirty_bitmap_get(BdrvDirtyBitmap *bitmap, int64_t offset) {
> 
> total: 1 errors, 0 warnings, 72 lines checked
> 
> Patch 10/18 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 11/18 Checking commit 1a5bc8c73750 (block/backup: upgrade copy_bitmap to 
> BdrvDirtyBitmap)
> WARNING: line over 80 characters
> #60: FILE: block/backup.c:174:
> +    bdrv_reset_dirty_bitmap(job->copy_bitmap, start, job->cluster_size * 
> nr_clusters);
> 
> WARNING: line over 80 characters
> #66: FILE: block/backup.c:179:
> +        bdrv_set_dirty_bitmap(job->copy_bitmap, start, job->cluster_size * 
> nr_clusters);
> 
> total: 0 errors, 2 warnings, 192 lines checked
> 
> Patch 11/18 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 12/18 Checking commit c7870c05906a (block/backup: add 'always' bitmap sync 
> policy)
> WARNING: Block comments use a leading /* on a separate line
> #41: FILE: block/backup.c:273:
> +        /* We succeeded, or we always intended to sync the bitmap.
> 
> WARNING: Block comments use a trailing */ on a separate line
> #42: FILE: block/backup.c:274:
> +         * Delete this bitmap and install the child. */
> 
> WARNING: Block comments use a leading /* on a separate line
> #46: FILE: block/backup.c:277:
> +        /* We failed, or we never intended to sync the bitmap anyway.
> 
> WARNING: Block comments use a trailing */ on a separate line
> #47: FILE: block/backup.c:278:
> +         * Merge the successor back into the parent, keeping all data. */
> 
> total: 0 errors, 4 warnings, 47 lines checked
> 
> Patch 12/18 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 13/18 Checking commit 2925d97a5717 (iotests: add testing shim for 
> script-style python tests)
> 14/18 Checking commit b491804bec4e (iotests: teach run_job to cancel pending 
> jobs)
> 15/18 Checking commit 9805af48ccbb (iotests: teach FilePath to produce 
> multiple paths)
> WARNING: line over 80 characters
> #63: FILE: tests/qemu-iotests/iotests.py:392:
> +    """FilePath is a specialization of FilePaths that takes a single 
> filename."""
> 
> total: 0 errors, 1 warnings, 67 lines checked
> 
> Patch 15/18 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 16/18 Checking commit 0d47743c9c1e (iotests: Add virtio-scsi device helper)
> 17/18 Checking commit 485221328b28 (iotests: add test 257 for bitmap-mode 
> backups)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #11: 
> new file mode 100755
> 
> total: 0 errors, 1 warnings, 2612 lines checked
> 
> Patch 17/18 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 18/18 Checking commit 18acfee9986a (block/backup: loosen restriction on 
> readonly bitmaps)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to address@hidden
> 

-- 
—js