[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/3] qapi: block-dirty-bitmap-re
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/3] qapi: block-dirty-bitmap-remove transaction action |
Date: |
Fri, 26 Jul 2019 17:26:14 +0000 |
24.07.2019 15:52, John Snow wrote:
>
>
> On 7/24/19 7:12 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 15.07.2019 22:48, John Snow wrote:
>>>
>>>
>>> On 7/8/19 6:04 PM, John Snow wrote:
>>>> Hi, this is a proposal based off of Vladimir's patchset:
>>>> [Qemu-devel] [PATCH 0/4] qapi: block-dirty-bitmap-remove transaction action
>>>>
>>>> ===
>>>> V3:
>>>> ===
>>>>
>>>> 001/3:[----] [--] 'blockdev: reduce aio_context locked sections in bitmap
>>>> add/remove'
>>>> 002/3:[0024] [FC] 'qapi: implement block-dirty-bitmap-remove transaction
>>>> action'
>>>> 003/3:[----] [--] 'iotests: test bitmap moving inside 254'
>>>>
>>>> - Changed "squelch_persistence" to "skip_store"
>>>> - Use Max's suggestion for return expr
>>>>
>>>> ===
>>>> V2:
>>>> ===
>>>>
>>>> It replaces patches two and three with a modified patch (now patch 2)
>>>> that foregoes the need for a hide()/unhide() bitmap API. I think it's
>>>> suitable as a smaller alternative, but I'm not sure if it covers all
>>>> of the use cases of the original series.
>>>>
>>>> Patches 1 and 3 (formerly 4) included as-is.
>>>>
>>>> John Snow (1):
>>>> qapi: implement block-dirty-bitmap-remove transaction action
>>>>
>>>> Vladimir Sementsov-Ogievskiy (2):
>>>> blockdev: reduce aio_context locked sections in bitmap add/remove
>>>> iotests: test bitmap moving inside 254
>>>>
>>>> block.c | 2 +-
>>>> block/dirty-bitmap.c | 15 +++--
>>>> blockdev.c | 105 ++++++++++++++++++++++++++-------
>>>> include/block/dirty-bitmap.h | 2 +-
>>>> migration/block-dirty-bitmap.c | 2 +-
>>>> qapi/transaction.json | 2 +
>>>> tests/qemu-iotests/254 | 30 +++++++++-
>>>> tests/qemu-iotests/254.out | 82 +++++++++++++++++++++++++
>>>> 8 files changed, 206 insertions(+), 34 deletions(-)
>>>>
>>>
>>> Thanks, applied to my bitmaps tree:
>>>
>>> https://github.com/jnsnow/qemu/commits/bitmaps
>>> https://github.com/jnsnow/qemu.git
>>>
>>> --js
>>>
>>>
>>> (Vladimir: if this isn't amenable to you, it's going in for 4.2, so we
>>> have until the next freeze to change it. Let me know, OK?)
>>>
>>
>>
>> And finally I'm here :)
>>
>> Thanks a lot for doing this job and for your explanations in other threads
>> which
>> I'm reading today and sorry for the delay! I'll look through these series
>> soon.
>>
>> Actually, my second child (girl:) was born a month ago, and then her elder
>> brother
>> was ill, so I took two weeks sick leave after about two weeks vacation and
>> forget
>> about work for a month.
>>
>> Hmm. And Nikolay, who doing libvirt part is on vocation now (I started
>> bitmap remove
>> transaction series by his request), so I don't know about the end of the
>> story with
>> release and this functionality..
>>
>> Anyway, it's cool, thanks!
>>
>
> Wow!
>
> Congratulations Vladimir!
>
Thank you!
--
Best regards,
Vladimir
- [Qemu-block] [PATCH v3 2/3] qapi: implement block-dirty-bitmap-remove transaction action, (continued)