Re: [Qemu-block] [PATCH v2 for-4.1 0/2] backup: Copy only dirty areas

[Max Reitz]

On 02.08.19 15:34, Kevin Wolf wrote:
> Am 01.08.2019 um 19:38 hat Max Reitz geschrieben:
>> Hi,
>>
>> In a discussion with Vladimir today, we noticed that the backup job
>> currently is pretty broken when using copy offloading.  I don’t know
>> about you, but my local filesystem (XFS) supports copy offloading, so
>> the job uses it automatically.  That means, that backup is broken and
>> has been broken for a year on my local FS.
>>
>> The last working version was 2.12, so this isn’t a regression in 4.1.
>> We could thus justify moving it to 4.2.  But I think this should really
>> go into 4.1, because this is not really an edge case and as far as I
>> know users cannot do anything to prevent the backup job from performing
>> copy offloading if the system and all involved block drivers support it.
>> I just wonder why nobody has noticed...
> 
> This sounds bad indeed. But are we already going to have an -rc4 for
> other reasons, or would this mean to have one only for the backup fix?

Looks like we are going to have an rc4 in any case because of the slirp
submodule.

> Also, if you say this was broken in 4.0, Cc: qemu-stable

Oh, right.  I have been forgetting that for quite a while now.

Max

signature.asc
Description: OpenPGP digital signature