Re: [Qemu-block] [PATCH v2 00/12] block: qiov_offset parameter for io

[Stefan Hajnoczi]

On Thu, Aug 15, 2019 at 11:12:35AM +0000, Vladimir Sementsov-Ogievskiy wrote:
> 29.07.2019 18:24, Stefan Hajnoczi wrote:
> > On Tue, Jun 04, 2019 at 07:15:02PM +0300, Vladimir Sementsov-Ogievskiy 
> > wrote:
> >> Hi all!
> >>
> >> Here is new parameter qiov_offset for io path, to avoid
> >> a lot of places with same pattern of creating local_qiov or hd_qiov
> >> variables.
> >>
> >> These series also includes my
> >> "[Qemu-devel] [PATCH 0/2] block/io: refactor padding"
> >> with some changes [described in 01 and 03 emails]
> >>
> >> Vladimir Sementsov-Ogievskiy (12):
> >>    util/iov: introduce qemu_iovec_init_extended
> >>    util/iov: improve qemu_iovec_is_zero
> >>    block/io: refactor padding
> >>    block: define .*_part io handlers in BlockDriver
> >>    block/io: bdrv_co_do_copy_on_readv: use and support qiov_offset
> >>    block/io: bdrv_co_do_copy_on_readv: lazy allocation
> >>    block/io: bdrv_aligned_preadv: use and support qiov_offset
> >>    block/io: bdrv_aligned_pwritev: use and support qiov_offset
> >>    block/io: introduce bdrv_co_p{read,write}v_part
> >>    block/qcow2: refactor qcow2_co_preadv to use buffer-based io
> >>    block/qcow2: implement .bdrv_co_preadv_part
> >>    block/qcow2: implement .bdrv_co_pwritev(_compressed)_part
> >>
> >>   block/qcow2.h             |   1 +
> >>   include/block/block_int.h |  21 ++
> >>   include/qemu/iov.h        |  10 +-
> >>   block/backup.c            |   2 +-
> >>   block/io.c                | 532 ++++++++++++++++++++++----------------
> >>   block/qcow2-cluster.c     |  14 +-
> >>   block/qcow2.c             | 131 +++++-----
> >>   qemu-img.c                |   4 +-
> >>   util/iov.c                | 153 +++++++++--
> >>   9 files changed, 559 insertions(+), 309 deletions(-)
> >>
> >> -- 
> >> 2.18.0
> > 
> > Thanks, applied to my block tree:
> > https://github.com/stefanha/qemu/commits/block
> > 
> > Stefan
> > 
> 
> Could you please squash this into 01:
> 
> diff --git a/util/iov.c b/util/iov.c
> index 0ed75e764c..5059e10431 100644
> --- a/util/iov.c
> +++ b/util/iov.c
> @@ -422,7 +422,7 @@ void qemu_iovec_init_extended(
>           void *tail_buf, size_t tail_len)
>   {
>       size_t mid_head, mid_tail;
> -    int total_niov, mid_niov;
> +    int total_niov, mid_niov = 0;
>       struct iovec *p, *mid_iov;
> 
>       if (mid_len) {

Done.  Sending the pull request today.

Stefan

signature.asc
Description: PGP signature