On 8/27/19 2:59 PM, Nir Soffer wrote:
> While working on 4k support, I noticed that there is lot of code using
> BDRV_SECTOR_SIZE (512) for checking alignment. I wonder how this can work with
> 4k storage.
>
> Lets start by cleaning up to make the code easier to understand:
> - Use QEMU_IS_ALIGNED macro to check alignment
> - Remove unneeded masks based on BDRV_SECTOR_SIZE
>
> Nir Soffer (2):
> block: Use QEMU_IS_ALIGNED
> block: Remove unused masks
>
> block/bochs.c | 4 ++--
> block/cloop.c | 4 ++--
> block/dmg.c | 4 ++--
> block/io.c | 8 ++++----
> block/qcow2-cluster.c | 4 ++--
> block/qcow2.c | 4 ++--
> block/vvfat.c | 8 ++++----
> include/block/block.h | 2 --
> migration/block.c | 2 +-
> qemu-img.c | 2 +-
> 10 files changed, 20 insertions(+), 22 deletions(-)
>
V2 changelog?
(Looks like adding patch 2 as a result of changing away users from the
BDRV_SECTOR_MASK.)
Right.
Changes since v1:
- Replace usage of BDRV_SECTOR_MASK in qcow2-cluster.c (Max)
- Remove unused masks
v1 was here:
Reviewed-by: John Snow <address@hidden>
Thanks!