[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM f
From: |
Peter Maydell |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller |
Date: |
Mon, 9 Sep 2019 17:21:08 +0100 |
On Mon, 9 Sep 2019 at 17:18, Dr. David Alan Gilbert <address@hidden> wrote:
>
> * Peter Maydell (address@hidden) wrote:
> > Missing reset and VMState for migration. These should be
> > baseline requirements for adding new device models to the
> > tree, because in an ideal world every device would support
> > both -- we should be gradually fixing the existing devices
> > which are missing these, and not letting new devices in,
> > so the situation gets gradually better, not worse.
>
> I'm happy to see things marked unmigratable instead for obscure
> devices; I don't see the need to worry about migration for stuff
> that's not going to be migrated.
VM snapshot save/restore is a useful debug tool. But yes,
"mark as nonmigratable explicitly" is OK too -- at least
that way if the user tries it they get a clear error message,
and we can later on look through to find what devices
are missing the capability. (Personally I find it's just
as easy to just implement the vmstate struct, though.)
thanks
-- PMM
- [Qemu-block] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine, Laurent Vivier, 2019/09/09
- [Qemu-block] [PATCH v9 4/9] hw/m68k: implement ADB bus support for via, Laurent Vivier, 2019/09/09
- [Qemu-block] [PATCH v9 7/9] hw/m68k: add Nubus support for macfb video card, Laurent Vivier, 2019/09/09
- [Qemu-block] [PATCH v9 2/9] dp8393x: manage big endian bus, Laurent Vivier, 2019/09/09
- [Qemu-block] [PATCH v9 1/9] esp: add pseudo-DMA as used by Macintosh, Laurent Vivier, 2019/09/09
- [Qemu-block] [PATCH v9 5/9] hw/m68k: add macfb video card, Laurent Vivier, 2019/09/09
- [Qemu-block] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller, Laurent Vivier, 2019/09/09
- Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller, Aleksandar Markovic, 2019/09/09
- [Qemu-block] [PATCH v9 6/9] hw/m68k: add Nubus support, Laurent Vivier, 2019/09/09
- [Qemu-block] [PATCH v9 9/9] hw/m68k: define Macintosh Quadra 800, Laurent Vivier, 2019/09/09
- [Qemu-block] [PATCH v9 3/9] hw/m68k: add via support, Laurent Vivier, 2019/09/09
- Re: [Qemu-block] [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine, no-reply, 2019/09/09
- Re: [Qemu-block] [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine, no-reply, 2019/09/09