[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 12/12] qcrypto-luks: more rigorous
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 12/12] qcrypto-luks: more rigorous header checking |
|
Date: |
Tue, 17 Sep 2019 11:17:01 +0100 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Thu, Sep 12, 2019 at 12:17:10PM +0300, Maxim Levitsky wrote:
> Check that keyslots don't overlap with the data,
> and check that keyslots don't overlap with each other.
> (this is done using naive O(n^2) nested loops,
> but since there are just 8 keyslots, this doesn't really matter.
>
> Signed-off-by: Maxim Levitsky <address@hidden>
> ---
> crypto/block-luks.c | 52 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-block] [PATCH 07/12] qcrypto-luks: purge unused error codes from open callback, (continued)
- [Qemu-block] [PATCH 07/12] qcrypto-luks: purge unused error codes from open callback, Maxim Levitsky, 2019/09/12
- [Qemu-block] [PATCH 08/12] qcrypto-luks: extract store and load header, Maxim Levitsky, 2019/09/12
- [Qemu-block] [PATCH 09/12] qcrypto-luks: extract check and parse header, Maxim Levitsky, 2019/09/12
- [Qemu-block] [PATCH 10/12] qcrypto-luks: extract store key function, Maxim Levitsky, 2019/09/12
- [Qemu-block] [PATCH 11/12] qcrypto-luks: simplify the math used for keyslot locations, Maxim Levitsky, 2019/09/12
- [Qemu-block] [PATCH 12/12] qcrypto-luks: more rigorous header checking, Maxim Levitsky, 2019/09/12
- Re: [Qemu-block] [Qemu-devel] [PATCH 12/12] qcrypto-luks: more rigorous header checking,
Daniel P . Berrangé <=