Re: [PATCH v2 1/4] qemu-iotests: remove bash shebang from library files

[Eric Blake]

On 10/9/19 2:47 PM, Cleber Rosa wrote:
> Due to not being able to find a reason to have shebangs on files that
> are not executable.
>
> While at it, add a mode hint to emacs, which would be clueless or
> plain wrong about these containing shell code.
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
>   tests/qemu-iotests/common.config  | 2 +-
>   tests/qemu-iotests/common.filter  | 2 +-
>   tests/qemu-iotests/common.nbd     | 3 +--
>   tests/qemu-iotests/common.pattern | 2 +-
>   tests/qemu-iotests/common.qemu    | 2 +-
>   tests/qemu-iotests/common.rc      | 2 +-
>   tests/qemu-iotests/common.tls     | 2 +-
>   7 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config
> index 9bd1a5a6fc..b85a6a6f96 100644
> --- a/tests/qemu-iotests/common.config
> +++ b/tests/qemu-iotests/common.config
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env bash
> +# -*- emacs mode: sh -*-

I thought my version:
# hey emacs, this file will be sourced by bash -*- mode: sh -*-
was cuter, but that's not a requirement, and yours works  ;)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org