Re: [PATCH v2 4/6] util: introduce SharedResource

[Vladimir Sementsov-Ogievskiy]

22.10.2019 13:23, Max Reitz wrote:
> On 16.10.19 19:09, Vladimir Sementsov-Ogievskiy wrote:
>> Introduce an API for some shared splittable resource, like memory.
>> It's going to be used by backup. Backup uses both read/write io and
>> copy_range. copy_range may consume memory implictly, so the new API is
>> abstract: it doesn't allocate any real memory by but only hands out
> 
> -by
> 
>> tickets.
>>
>> The idea is that we have some total amount of something and callers
>> should wait in coroutine queue if there is not enough of the resource
>> at the moment.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>>   include/qemu/co-shared-resource.h | 71 +++++++++++++++++++++++++++++
>>   util/qemu-co-shared-resource.c    | 76 +++++++++++++++++++++++++++++++
>>   util/Makefile.objs                |  1 +
>>   3 files changed, 148 insertions(+)
>>   create mode 100644 include/qemu/co-shared-resource.h
>>   create mode 100644 util/qemu-co-shared-resource.c
>>
>> diff --git a/include/qemu/co-shared-resource.h 
>> b/include/qemu/co-shared-resource.h
>> new file mode 100644
>> index 0000000000..04c9c3d5be
>> --- /dev/null
>> +++ b/include/qemu/co-shared-resource.h
>> @@ -0,0 +1,71 @@
>> +/*
>> + * Helper functionality for distributing a fixed total amount of
>> + * an abstract resource among multiple coroutines.
>> + *
>> + * Copyright (c) 2019 Virtuozzo International GmbH
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining a 
>> copy
>> + * of this software and associated documentation files (the "Software"), to 
>> deal
>> + * in the Software without restriction, including without limitation the 
>> rights
>> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
>> + * copies of the Software, and to permit persons to whom the Software is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be included 
>> in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS 
>> OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR 
>> OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
>> FROM,
>> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
>> + * THE SOFTWARE.
>> + */
>> +
>> +#ifndef QEMU_CO_SHARED_AMOUNT_H
>> +#define QEMU_CO_SHARED_AMOUNT_H
> 
> You should probably adjust these include guards to match the new filename.
> 
> With those bits fixed:
> 
> Reviewed-by: Max Reitz <address@hidden>
> 

Thank for reviewing! I'll fix it and resend.

-- 
Best regards,
Vladimir