Re: [libvirt] [PULL v2 0/9] Ide patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [libvirt] [PULL v2 0/9] Ide patches
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
514c990 hd-geo-test: Add tests for lchs override
417c06b bootdevice: FW_CFG interface for LCHS values
95cff25 bootdevice: Refactor get_boot_devices_list
8338ac4 bootdevice: Gather LCHS from all relevant devices
74e4c54 scsi: Propagate unrealize() callback to scsi-hd
89e99d5 bootdevice: Add interface to gather LCHS
38a1f79 block: Support providing LCHS from user
fdb21cf block: Refactor macros - fix tabbing
a72c719 IDE: deprecate ide-drive

=== OUTPUT BEGIN ===
1/9 Checking commit a72c71949c97 (IDE: deprecate ide-drive)
2/9 Checking commit fdb21cf1b99a (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#58: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf)                      \
+    DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0),                  \
+    DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0),                \
     DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)

total: 1 errors, 0 warnings, 37 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit 38a1f79b0263 (block: Support providing LCHS from user)
4/9 Checking commit 89e99d5e95db (bootdevice: Add interface to gather LCHS)
5/9 Checking commit 74e4c54110a3 (scsi: Propagate unrealize() callback to 
scsi-hd)
6/9 Checking commit 8338ac4726f1 (bootdevice: Gather LCHS from all relevant 
devices)
7/9 Checking commit 95cff25ddcc7 (bootdevice: Refactor get_boot_devices_list)
8/9 Checking commit 417c06b79277 (bootdevice: FW_CFG interface for LCHS values)
9/9 Checking commit 514c99024108 (hd-geo-test: Add tests for lchs override)
WARNING: Block comments use a leading /* on a separate line
#607: FILE: tests/hd-geo-test.c:965:
+                       "skipping hd-geo/override/* tests");

total: 0 errors, 1 warnings, 578 lines checked

Patch 9/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden