[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] iotests: Test NBD client reconnection

From: Eric Blake
Subject: Re: [PATCH v4] iotests: Test NBD client reconnection
Date: Mon, 11 Nov 2019 11:53:36 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 11/11/19 4:04 AM, Andrey Shinkevich wrote:
The test for an NBD client. The NBD server is disconnected after the
client write request. The NBD client should reconnect and complete
the write operation.

Suggested-by: Denis V. Lunev <address@hidden>
Suggested-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: Andrey Shinkevich <address@hidden>
v3 was discussed in the email thread with the message ID

+import os
+import subprocess
+import iotests
+from iotests import file_path, log
+nbd_sock, conf_file = file_path('nbd-sock', "nbd-fault-injector.conf")

Mixing '' and "" in the same line is odd. I don't know if we have a strong preference for one style over the other.

+++ b/tests/qemu-iotests/group
@@ -284,3 +284,4 @@
 268 rw auto quick
 270 rw backing quick
 272 rw
+277 rw

The test completes in 3 seconds for me; we could add 'quick'.

Otherwise, looks reasonable to me.

Reviewed-by: Eric Blake <address@hidden>
Tested-by: Eric Blake <address@hidden>

I'll probably queue this through my NBD tree for rc1, as it adds test coverage of a new feature for the 4.2 release.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]