[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 15/26] qcow2: Add subcluster support to zero_in_l2_sli

From: Alberto Garcia
Subject: Re: [RFC PATCH v2 15/26] qcow2: Add subcluster support to zero_in_l2_slice()
Date: Thu, 14 Nov 2019 16:31:44 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Mon 04 Nov 2019 04:10:58 PM CET, Max Reitz wrote:
>>>          qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
>>>          if (cluster_type == QCOW2_CLUSTER_COMPRESSED || unmap) {
>>> -            set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO);
>>>              qcow2_free_any_clusters(bs, old_offset, 1, 
>> It feels wrong to me to free the cluster before updating the L2
>> entry.
> (Although it’s pre-existing, as set_l2_entry() is just an in-cache
> operation anyway :-/)

Yes, I think that if you want to do it afterwards you need to add
another loop after the qcow2_cache_put() call.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]