[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_
|
From: |
Max Reitz |
|
Subject: |
Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_slice() |
|
Date: |
Thu, 14 Nov 2019 17:22:42 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 14.11.19 16:33, Alberto Garcia wrote:
> On Mon 04 Nov 2019 04:07:35 PM CET, Max Reitz wrote:
>>> /* First remove L2 entries */
>>> qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
>>> - if (!full_discard && s->qcow_version >= 3) {
>>> + if (has_subclusters(s)) {
>>> + set_l2_entry(s, l2_slice, l2_index + i, 0);
>>> + set_l2_bitmap(s, l2_slice, l2_index + i,
>>> + full_discard ? 0 : QCOW_L2_BITMAP_ALL_ZEROES);
>>
>> But only for !full_discard, right?
>
> Hence the conditional operator in my patch, maybe you didn't see it?
Oops, yep, I was just hung up on the if conditional.
Max
signature.asc
Description: OpenPGP digital signature