[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete
From: |
Max Reitz |
Subject: |
Re: [PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete |
Date: |
Tue, 26 Nov 2019 09:27:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 08.11.19 13:34, Max Reitz wrote:
> Hi,
>
> v3 of this series was this:
>
> https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg00868.html
>
> In the meantime, I’ve merged the first patch, so the subject of the
> series has changed.
>
> In v4, I’ve tried to address Vladimir’s concern of how to map QAPI
> BlockPermission values to BLK_PERM_* flags with the new patches 1 and 2,
> and a minor change to patch 3:
> - Patch 1: Added, this new function will translate QAPI BlockPermission
> values to BLK_PERM_* flags
> - Patch 2: Added; we can make use of the new function in
> xdbg_graph_add_edge() to save some LoC
> - Patch 3:
> - %s/4.2/5.0/
> - Let blkdebug_parse_perm_list() initialize *dest
> - Use bdrv_qapi_perm_to_blk_perm() to translate QAPI BlockPermission
> values instead of blindly assuming an x -> 2^x mapping
Thanks for the review, applied to my block-next branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next
Max
signature.asc
Description: OpenPGP digital signature
- [PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete, Max Reitz, 2019/11/08
- [PATCH for-5.0 v4 2/5] block: Use bdrv_qapi_perm_to_blk_perm(), Max Reitz, 2019/11/08
- [PATCH for-5.0 v4 1/5] block: Add bdrv_qapi_perm_to_blk_perm(), Max Reitz, 2019/11/08
- [PATCH for-5.0 v4 3/5] blkdebug: Allow taking/unsharing permissions, Max Reitz, 2019/11/08
- [PATCH for-5.0 v4 5/5] iotests: Add test for failing mirror complete, Max Reitz, 2019/11/08
- [PATCH for-5.0 v4 4/5] iotests: Add @error to wait_until_completed, Max Reitz, 2019/11/08
- Re: [PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete,
Max Reitz <=