[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0 v2 02/23] blockdev: Allow resizing everywhere
From: |
Max Reitz |
Subject: |
Re: [PATCH for-5.0 v2 02/23] blockdev: Allow resizing everywhere |
Date: |
Mon, 9 Dec 2019 14:56:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 06.12.19 15:04, Alberto Garcia wrote:
> On Mon 11 Nov 2019 05:01:55 PM CET, Max Reitz wrote:
>> @@ -3177,11 +3177,6 @@ void qmp_block_resize(bool has_device, const char
>> *device,
>> aio_context = bdrv_get_aio_context(bs);
>> aio_context_acquire(aio_context);
>>
>> - if (!bdrv_is_first_non_filter(bs)) {
>> - error_setg(errp, QERR_FEATURE_DISABLED, "resize");
>> - goto out;
>> - }
>> -
>
> What happens with this case now?
>
> https://lists.gnu.org/archive/html/qemu-block/2019-11/msg00793.html
As far as I understand, we have a bug there and we’ll fix it in 5.0.
It’s just that in one case, it wasn’t visible because resize wasn’t
allowed on some nodes (where I think it should actually be allowed,
hence this patch).
So I think we should allow resize on those nodes (this patch) and fix
the bug, and that should be fine then.
Max
signature.asc
Description: OpenPGP digital signature