[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
Re: [PATCH for-5.0 v2 19/23] iotests: Resolve TODOs in 041 |
|
Date: |
Fri, 13 Dec 2019 11:31:43 +0000 |
09.12.2019 18:15, Max Reitz wrote:
> On 03.12.19 14:33, Vladimir Sementsov-Ogievskiy wrote:
>> 03.12.2019 16:32, Vladimir Sementsov-Ogievskiy wrote:
>>> 11.11.2019 19:02, Max Reitz wrote:
>>>> Signed-off-by: Max Reitz<address@hidden>
>>>
>>>
>>> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>>>
>>
>>
>> Oops, stop. Why do you remove line "self.vm.shutdown()" ?
>
> Because we don’t need it. tearDown() does it anyway. I suppose I
> should mention it in the commit message.
>
Yes...
But actually, better to remove extra shutdown from all test cases, not from
one, and than it would be separate patch.
Extra shutdown is left in (considering only class TestRepairQuorum):
test_pause
test_cancel_after_ready
test_cancel
test_complete
--
Best regards,
Vladimir