[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libvirt] [PATCH] virtio-blk: deprecate SCSI passthrough
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [libvirt] [PATCH] virtio-blk: deprecate SCSI passthrough |
|
Date: |
Fri, 13 Dec 2019 16:25:45 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 13/12/19 16:10, Daniel P. Berrangé wrote:
> I don't think it really matters. QEMU is deprecating it with no
> seemless direct replacement, so I don't think libvirt needs to
> be concerned. The feature simply becomes unsupported.
>
> At the very most we need to check if it exists before using it,
> but even that's just a nice to have which results in a slightly
> prettier error message.
Libvirt right now assumes that a QEMU without the scsi property defaults
to "on", but if the oldest supported QEMU version is 1.5.3 then it
already has the property. So you can just give an error if there is no
scsi property and device='lun'.
Paolo