[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/4] vl: Initialise main loop earlier
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 2/4] vl: Initialise main loop earlier |
Date: |
Wed, 15 Jan 2020 17:26:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> We want to be able to use qemu_aio_context in the monitor
> initialisation.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> vl.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 86474a55c9..4c79a00857 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2903,6 +2903,11 @@ int main(int argc, char **argv, char **envp)
> runstate_init();
> precopy_infrastructure_init();
> postcopy_infrastructure_init();
> +
> + if (qemu_init_main_loop(&main_loop_err)) {
> + error_report_err(main_loop_err);
> + exit(1);
> + }
> monitor_init_globals();
>
> if (qcrypto_init(&err) < 0) {
> @@ -3817,11 +3822,6 @@ int main(int argc, char **argv, char **envp)
> qemu_unlink_pidfile_notifier.notify = qemu_unlink_pidfile;
> qemu_add_exit_notifier(&qemu_unlink_pidfile_notifier);
>
> - if (qemu_init_main_loop(&main_loop_err)) {
> - error_report_err(main_loop_err);
> - exit(1);
> - }
> -
> #ifdef CONFIG_SECCOMP
> olist = qemu_find_opts_err("sandbox", NULL);
> if (olist) {
Can't see anything wrong with this. Doesn't mean much; every time I do
something like it, it comes back to bite me.
Reviewed-by: Markus Armbruster <address@hidden>
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, (continued)
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Markus Armbruster, 2020/01/15
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Kevin Wolf, 2020/01/15
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Markus Armbruster, 2020/01/16
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Kevin Wolf, 2020/01/16
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Markus Armbruster, 2020/01/17
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Kevin Wolf, 2020/01/17
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Markus Armbruster, 2020/01/17
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Kevin Wolf, 2020/01/17
- Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands, Markus Armbruster, 2020/01/17
[PATCH v3 2/4] vl: Initialise main loop earlier, Kevin Wolf, 2020/01/15
- Re: [PATCH v3 2/4] vl: Initialise main loop earlier,
Markus Armbruster <=
[PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Kevin Wolf, 2020/01/15
- Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Markus Armbruster, 2020/01/16
- Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Kevin Wolf, 2020/01/16
- Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Markus Armbruster, 2020/01/16
- Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Kevin Wolf, 2020/01/16
- Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Markus Armbruster, 2020/01/17
- Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Kevin Wolf, 2020/01/17
- Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Markus Armbruster, 2020/01/17
Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Markus Armbruster, 2020/01/17
Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine, Kevin Wolf, 2020/01/17