[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iotests: Remove the superfluous 2nd check for the availabili

From: Andrey Shinkevich
Subject: Re: [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum
Date: Fri, 31 Jan 2020 15:17:58 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 29/01/2020 17:17, Thomas Huth wrote:
Commit d9df28e7b07 ("iotests: check whitelisted formats") added the
modern @iotests.skip_if_unsupported() to the functions in this test,
so we don't need the old explicit test here anymore.

Signed-off-by: Thomas Huth <address@hidden>
  tests/qemu-iotests/139 | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/tests/qemu-iotests/139 b/tests/qemu-iotests/139
index cbb5a76530..2f075888ba 100755
--- a/tests/qemu-iotests/139
+++ b/tests/qemu-iotests/139
@@ -344,9 +344,6 @@ class TestBlockdevDel(iotests.QMPTestCase):
      def testQuorum(self):
-        if not iotests.supports_quorum():
-            return
          self.addQuorum('quorum0', 'node0', 'node1')
          # We cannot remove the children of a Quorum device
          self.delBlockDriverState('node0', expect_error = True)

Reviewed-by: Andrey Shinkevich <address@hidden>
Tested-by: Andrey Shinkevich <address@hidden>
With the best regards,
Andrey Shinkevich

reply via email to

[Prev in Thread] Current Thread [Next in Thread]