[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] m25p80: Convert to support tracing

From: Guenter Roeck
Subject: Re: [PATCH 1/3] m25p80: Convert to support tracing
Date: Wed, 5 Feb 2020 10:34:32 -0800
User-agent: Mutt/1.9.4 (2018-02-28)

On Wed, Feb 05, 2020 at 06:10:44PM +0100, Cédric Le Goater wrote:
> On 2/5/20 5:35 PM, Guenter Roeck wrote:
> > On Wed, Feb 05, 2020 at 11:05:04AM +0100, Cédric Le Goater wrote:
> >> On 2/3/20 7:09 PM, Guenter Roeck wrote:
> >>> While at it, add some trace messages to help debug problems
> >>> seen when running the latest Linux kernel.
> >>
> >> In case you resend, It would be nice to printout a flash id in the tracing
> >> else I have a patch for it on top of yours. It helped me track a squashfs
> >> corruption on the Aspeed witherspoon-bmc machine which we were after since
> >> 2017 or so. It seems to be a kernel bug.
> >>
> > 
> > I'll send a new version to split patch 2. Not sure I understand what you 
> > mean
> > with the above. If you send me your patch I'll be happy to merge it into 
> > mine,
> > otherwise we can just keep it as follow-ip patch.
> Here is the idea : 
> https://github.com/legoater/qemu/commit/a07727e9cfc8447ea18249ff68a561f7e8883584

Ah, that. I had thought about doing that, but I found displaying the pointer
a bit clumsy. It looks like there isn't really anything else available that
would provide a flash index, and I agree that it would be useful, so I'll
add it for all traces.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]