[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] qapi: Document meaning of 'ignore' BlockdevOnError for j

From: Ján Tomko
Subject: Re: [PATCH 1/7] qapi: Document meaning of 'ignore' BlockdevOnError for jobs
Date: Sun, 16 Feb 2020 22:44:30 +0100

On Fri, Feb 14, 2020 at 09:08:06PM +0100, Kevin Wolf wrote:
It is not obvious what 'ignore' actually means for block jobs: It could
be continuing the job and returning success in the end despite the error
(no block job does this). It could also mean continuing and returning
failure in the end (this is what stream does). And it can mean retrying
the failed request later (this is what backup, commit and mirror do).

This (somewhat inconsistent) behaviour was introduced and described for
stream and mirror in commit ae586d6158. backup and commit were

fatal: ambiguous argument 'ae586d6158': unknown revision or path not in the 
working tree.

introduced later and use the same model as mirror.

Signed-off-by: Kevin Wolf <address@hidden>
qapi/block-core.json | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Ján Tomko <address@hidden>


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]