[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/7] commit: Expose on-error option in QMP

From: Ján Tomko
Subject: Re: [PATCH 6/7] commit: Expose on-error option in QMP
Date: Sun, 16 Feb 2020 22:47:18 +0100

On Fri, Feb 14, 2020 at 09:08:11PM +0100, Kevin Wolf wrote:
Now that the error handling in the common block job is fixed, we can
expose the on-error option in QMP instead of hard-coding it as 'report'
in qmp_block_commit().

This fulfills the promise that the old comment in that function made,
even if a bit later than expected: "This will be part of the QMP
command, if/when the BlockdevOnError change for blkmirror makes it in".

Signed-off-by: Kevin Wolf <address@hidden>
qapi/block-core.json | 4 ++++
blockdev.c           | 8 ++++----
2 files changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Ján Tomko <address@hidden>


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]