[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment
Date: Mon, 17 Feb 2020 11:24:43 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

15.02.2020 19:15, Philippe Mathieu-Daudé wrote:
Fix warning reported by Clang static code analyzer:

     CC      block/qcow2-bitmap.o
   block/qcow2-bitmap.c:650:5: warning: Value stored to 'ret' is never read
       ret = -EINVAL;
       ^     ~~~~~~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
  block/qcow2-bitmap.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index d41f5d049b..8cccc2c9f3 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -647,7 +647,6 @@ static Qcow2BitmapList *bitmap_list_load(BlockDriverState 
*bs, uint64_t offset,
      return bm_list;
-    ret = -EINVAL;
      error_setg(errp, "Broken bitmap directory");

Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]