[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v3 06/27] qcow2: Add dummy has_subclusters() function

From: Eric Blake
Subject: Re: [RFC PATCH v3 06/27] qcow2: Add dummy has_subclusters() function
Date: Thu, 20 Feb 2020 09:24:08 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 12/22/19 5:36 AM, Alberto Garcia wrote:
This function will be used by the qcow2 code to check if an image has
subclusters or not.

At the moment this simply returns false. Once all patches needed for
subcluster support are ready then QEMU will be able to create and
read images with subclusters and this function will return the actual

Signed-off-by: Alberto Garcia <address@hidden>
  block/qcow2.h | 6 ++++++
  1 file changed, 6 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

diff --git a/block/qcow2.h b/block/qcow2.h
index 6823d3f68f..1db3fc5dbc 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -495,6 +495,12 @@ typedef enum QCow2MetadataOverlap {
#define INV_OFFSET (-1ULL) +static inline bool has_subclusters(BDRVQcow2State *s)
+    /* FIXME: Return false until this feature is complete */
+    return false;
  static inline uint64_t get_l2_entry(BDRVQcow2State *s, uint64_t *l2_slice,
                                      int idx)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]