[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 27/27] iotests: Add tests for qcow2 images with extend
Re: [RFC PATCH v3 27/27] iotests: Add tests for qcow2 images with extended L2 entries
Fri, 21 Feb 2020 18:04:42 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1
On 22.12.19 12:37, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <address@hidden>
> tests/qemu-iotests/271 | 256 +++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/271.out | 208 ++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 465 insertions(+)
> create mode 100755 tests/qemu-iotests/271
> create mode 100644 tests/qemu-iotests/271.out
Currently, you’re using the reference output to verify the results. I
find this rather difficult.
Can this not be written in a way that the test itself verifies the
results? I realize bit manipulation in bash is hard, which is why I
wonder whether Python may be better suited for the job.
Or maybe at least there could be some way to produce a hexdump-like
result from some more abstract description on what to expect and then
compare the strings.
I suppose I can live with how it is, but I feel like I’d have to do
something in my head that could be better done by a script.
Description: OpenPGP digital signature
|[Prev in Thread]
||[Next in Thread]|
- Re: [RFC PATCH v3 27/27] iotests: Add tests for qcow2 images with extended L2 entries,
Max Reitz <=