[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ping Re: [PATCH for-5.0 v2 0/3] benchmark util

From: Vladimir Sementsov-Ogievskiy
Subject: Re: ping Re: [PATCH for-5.0 v2 0/3] benchmark util
Date: Fri, 28 Feb 2020 09:24:56 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

27.02.2020 23:09, Eduardo Habkost wrote:
Sorry, this is due to lack of bandwidth of maintainers who can
review those patches.

I have one suggestion: if you make your script self-contained
inside a scripts/ subdirectory, it would be simpler to merge it
without detailed reviews from others.

That works for me

The python/ subdirectory is supposed to appear on sys.path, so

Hmm. Ok, I think, we'll always be able to move shareable parts of simplebench
into python/ if needed. So it's OK to keep it in scripts. I just
thought that python/ is a new home for python scripts :) So, it's OK
to keep the whole thing at scripts/ for now.

maybe simplebench.py and qemu/bench_block_job.py can stay there,
but bench-example.py is not a loadable Python module and
shouldn't be there.

I see two possible options:

a) Moving everything to a scripts/simplebench subdirectory.
b) Moving only bench-example.py to scripts/, and do the sys.path
    hacking the other scripts do.

On either case, please add your name to MAINTAINERS as the
maintainer of those new files.

OK, thanks!

On Thu, Feb 27, 2020 at 04:18:00PM +0300, Vladimir Sementsov-Ogievskiy wrote:

Is problem in "S: Odd fixes" in Python section of MAINTAINERS?

Will it be correct, if I send a patch to MAINTAINERS, proposing
myself as maintainer of Python scripts and s/Odd fixes/Maintained/ ?

And then just send pull request with this series, as "nobody minds"?

08.02.2020 13:36, Vladimir Sementsov-Ogievskiy wrote:

Hi! Could it be merged at all?

20.01.2020 12:10, Vladimir Sementsov-Ogievskiy wrote:

26.11.2019 18:48, Vladimir Sementsov-Ogievskiy wrote:
Hi all!

Here is simple benchmarking utility, to generate performance
comparison tables, like the following:

----------  -------------  -------------  -------------
              backup-1       backup-2       mirror
ssd -> ssd  0.43 +- 0.00   4.48 +- 0.06   4.38 +- 0.02
ssd -> hdd  10.60 +- 0.08  10.69 +- 0.18  10.57 +- 0.05
ssd -> nbd  33.81 +- 0.37  10.67 +- 0.17  10.07 +- 0.07
----------  -------------  -------------  -------------

This is a v2, as v1 was inside
   "[RFC 00/24] backup performance: block_status + async"

I'll use this benchmark in other series, hope someone
will like it.

Vladimir Sementsov-Ogievskiy (3):
    python: add simplebench.py
    python: add qemu/bench_block_job.py
    python: add example usage of simplebench

   python/bench-example.py        |  80 +++++++++++++++++++++
   python/qemu/bench_block_job.py | 115 +++++++++++++++++++++++++++++
   python/simplebench.py          | 128 +++++++++++++++++++++++++++++++++
   3 files changed, 323 insertions(+)
   create mode 100644 python/bench-example.py
   create mode 100755 python/qemu/bench_block_job.py
   create mode 100644 python/simplebench.py

Best regards,

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]