|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 7/7] aio-posix: remove idle poll handlers to improve scalability |
Date: | Thu, 5 Mar 2020 18:28:29 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 05/03/20 18:08, Stefan Hajnoczi wrote: > + /* > + * List of handlers participating in userspace polling. Accessed almost > + * exclusively from aio_poll() and therefore not an RCU list. Protected > by > + * ctx->list_lock. > + */ > + AioHandlerList poll_aio_handlers; > + Not sure I understand the "almost" part. If it's accessed only from aio_poll() it is protected via either AIO_WAIT_WHILE or the BQL, not by ctx->list_lock; if it's protected by ctx->list_lock (using qemu_lockcnt_inc in readers), it is an RCU list. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |