Re: [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied

[John Snow]

CC qemu-block and qcow2 maintainers

(Use scripts/get_maintainer.pl to identify maintainers.)

On 3/9/20 12:35 PM, Yi Li wrote:
> The QCowL2Meta **m parameter is not used
> 
> Signed-off-by: Yi Li <address@hidden>
> ---
>  block/qcow2-cluster.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index 17f1363..db9efa5 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -1154,7 +1154,7 @@ static int handle_dependencies(BlockDriverState *bs, 
> uint64_t guest_offset,
>   *  -errno: in error cases
>   */
>  static int handle_copied(BlockDriverState *bs, uint64_t guest_offset,
> -    uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
> +    uint64_t *host_offset, uint64_t *bytes)
>  {
>      BDRVQcow2State *s = bs->opaque;
>      int l2_index;
> @@ -1567,7 +1567,7 @@ again:
>          /*
>           * 2. Count contiguous COPIED clusters.
>           */
> -        ret = handle_copied(bs, start, &cluster_offset, &cur_bytes, m);
> +        ret = handle_copied(bs, start, &cluster_offset, &cur_bytes);
>          if (ret < 0) {
>              return ret;
>          } else if (ret) {
> 

Seems OK to me -- it is definitely unused.
(Is _that_ a problem?  For qcow2 maintainers to know.)

Reviewed-by: John Snow <address@hidden>