[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F
From: |
Kashyap Chamarthy |
Subject: |
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F |
Date: |
Tue, 10 Mar 2020 11:57:46 +0100 |
On Mon, Mar 09, 2020 at 10:42:25AM -0500, Eric Blake wrote:
[...]
> > > +qemu-img backing file without format (since 5.0.0)
> > > +''''''''''''''''''''''''''''''''''''''''''''''''''
> > > +
> > > +The use of ``qemu-img create``, ``qemu-img rebase``, ``qemu-img
> > > +convert``, or ``qemu-img amend`` to create or modify an image that
> > > +depends on a backing file now recommends that an explicit backing
> > > +format be provided.
Also for the `qemu-img amend` case, I'm not clear if the following scenario
ought to throw the warning:
$> ~/build/qemu/qemu-img info --backing-chain overlay1.qcow2
image: overlay1.qcow2
file format: qcow2
virtual size: 4 GiB (4294967296 bytes)
disk size: 196 KiB
cluster_size: 65536
backing file: base.raw
Format specific information:
compat: 1.1
lazy refcounts: false
refcount bits: 16
corrupt: false
image: base.raw
file format: raw
virtual size: 4 GiB (4294967296 bytes)
disk size: 778 MiB
$> ~/build/qemu/qemu-img amend -o compat=v3 overlay1.qcow2
$> echo $?
0
I'm just trying to work out the scenarios where the warnings ought to
show up (for all the four cases: create, rebase, convert, amend).
[...]
--
/kashyap
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, (continued)
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, Daniel P . Berrangé, 2020/03/09
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, Eric Blake, 2020/03/09
[PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Eric Blake, 2020/03/06
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F,
Kashyap Chamarthy <=
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Eric Blake, 2020/03/10
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Eric Blake, 2020/03/10
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Kashyap Chamarthy, 2020/03/10
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Eric Blake, 2020/03/13
[PATCH v3 3/4] block: Add support to warn on backing file change without format, Eric Blake, 2020/03/06
[PATCH v3 2/4] iotests: Specify explicit backing format where sensible, Eric Blake, 2020/03/06