Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

[Vladimir Sementsov-Ogievskiy]

11.03.2020 12:33, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy <address@hidden> writes:
>
> > 09.03.2020 12:56, Markus Armbruster wrote:
> > > > +
> > > > +// Convert error clearing functions
> > > Suggest: Ensure @local_err is cleared on free
> >
> > But there is no local_err after conversion
>
> True.  Hmm.  What about this:
>
>       // Convert calls to error_free(), possibly indirect
>       // In addition to replacing @local_err by *errp, we have to clear *errp
>       // to avoid use-after-free in the automatic error propagation.

OK

> > > > +(
> > > > +-    error_free(local_err);
> > > > ++    error_free_errp(errp);
> > > > +|
> > > > +-    error_report_err(local_err);
> > > > ++    error_report_errp(errp);
> > > > +|
> > > > +-    error_reportf_err(local_err, args);
> > > > ++    error_reportf_errp(errp, args);
> > > > +|
> > > > +-    warn_report_err(local_err);
> > > > ++    warn_report_errp(errp);
> > > > +|
> > > > +-    warn_reportf_err(local_err, args);


--
Best regards,
Vladimir