[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/3] hw/misc/ivshmem: Use one Error * variable instead of two
From: |
Markus Armbruster |
Subject: |
[PATCH 2/3] hw/misc/ivshmem: Use one Error * variable instead of two |
Date: |
Fri, 13 Mar 2020 18:05:16 +0100 |
Commit fe44dc9180 "migration: disallow migrate_add_blocker during
migration" accidentally added a second Error * variable. Use the
first one instead.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/misc/ivshmem.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 1a0fad74e1..a8dc9b377d 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -832,7 +832,6 @@ static void ivshmem_common_realize(PCIDevice *dev, Error
**errp)
IVShmemState *s = IVSHMEM_COMMON(dev);
Error *err = NULL;
uint8_t *pci_conf;
- Error *local_err = NULL;
/* IRQFD requires MSI */
if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD) &&
@@ -899,9 +898,9 @@ static void ivshmem_common_realize(PCIDevice *dev, Error
**errp)
if (!ivshmem_is_master(s)) {
error_setg(&s->migration_blocker,
"Migration is disabled when using feature 'peer mode' in
device 'ivshmem'");
- migrate_add_blocker(s->migration_blocker, &local_err);
- if (local_err) {
- error_propagate(errp, local_err);
+ migrate_add_blocker(s->migration_blocker, &err);
+ if (err) {
+ error_propagate(errp, err);
error_free(s->migration_blocker);
return;
}
--
2.21.1
- Re: [PATCH 3/3] xen-block: Use one Error * variable instead of two, (continued)
[PATCH 1/3] Use &error_abort instead of separate assert(), Markus Armbruster, 2020/03/13
[PATCH 2/3] hw/misc/ivshmem: Use one Error * variable instead of two,
Markus Armbruster <=
Re: [PATCH 0/3] Minor error handling cleanups, Peter Maydell, 2020/03/13
[PATCH v10 4/3] hw/sd/ssi-sd: fix error handling in ssi_sd_realize, Vladimir Sementsov-Ogievskiy, 2020/03/17
Re: [PATCH 0/3] Minor error handling cleanups, Markus Armbruster, 2020/03/17